| mwalle | mh put_user is broken | 11:53 |
|---|---|---|
| mwalle | in asm-generic | 11:53 |
| mwalle | or our compiler | 11:53 |
| mwalle | put_user(a, b++) increments b twice.. | 11:58 |
| larsc | it's put_user... grml | 14:13 |
| larsc | mwalle: in case you haven't fixed it yet http://pastebin.com/ckNrNZVZ | 14:18 |
| mwalle | larsc: yes and get_user has the same issue, hasnt it? | 14:36 |
| mwalle | and im not sure about __{put,get}_user | 14:37 |
| mwalle | i think we should refactor it like in the m32r port | 14:38 |
| larsc | it has | 14:46 |
| mwalle | ok the tile arch is better: ) | 14:53 |
| larsc | imo the current generic code is ok. with the same fix applied to get_user | 14:58 |
| mwalle | __{get,put}_user uses ptr twice too.. | 15:01 |
| mwalle | but __chk_user_ptr is likely to defined to null | 15:01 |
| larsc | __chk_user_ptr should never expand to any actuall code | 15:02 |
| larsc | oh, sorry, nvm, i'm wrong | 15:02 |
| larsc | on the other hand i'm seemed to be wrong, when i thought i was wrong | 15:16 |
| mwalle | http://pastebin.com/f9i4tvNH << what about that? | 15:17 |
| larsc | mwalle: you'll be on the save side with it, but __chk_user_ptr will always be a noop when compiling the code | 15:26 |
| --- Sun Jan 30 2011 | 00:00 | |
Generated by irclog2html.py 2.9.2 by Marius Gedminas - find it at mg.pov.lt!